Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2291 first class support for playwright #2421

Conversation

f-delahaye
Copy link
Contributor

@f-delahaye f-delahaye commented Oct 22, 2023

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

New playwright driver using Playwright java apis.
Add the karate-playwright module in your pom.xml before karate-core to enable it.

@ptrthomas
Copy link
Member

@f-delahaye I've made changes to align with develop and got the build to pass. let me know if you are ok with the changes and I will merge

was able to run playwright runner locally. does it download the playwright runtime the first time ? is there a way to get that to show in the log

Frédéric added 2 commits October 24, 2023 19:05
@f-delahaye
Copy link
Contributor Author

@f-delahaye I've made changes to align with develop and got the build to pass. let me know if you are ok with the changes and I will merge

Sure. Thanks for fixing the build!

was able to run playwright runner locally. does it download the playwright runtime the first time ? is there a way to get that to show in the log

It does. I have added a log.
For completeness, it is possible to pass playwrightOptions.installBowsers = false to disable auto installing. playwrightOptions.channel = chrome may then be specified to tell Playwright to use the locally installed browser instead

@ptrthomas ptrthomas merged commit 1edb923 into karatelabs:develop Oct 25, 2023
1 check passed
@ptrthomas
Copy link
Member

@f-delahaye I'm planning to post this news around to get more eyeballs on this work. do you have a social media presence beyond github you'd like to be tagged in ? if you can also get on a call so we can say hi that would be great ! please e-mail me: peter (at) karatelabs.io

@ptrthomas ptrthomas added this to the 1.5.0 milestone Jul 26, 2024
@ptrthomas ptrthomas removed the fixed label Jul 26, 2024
@ptrthomas ptrthomas removed this from the 1.5.0 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants