🐛 choose latest version on upgrade

[jimmykarily]

Part of the fix for: kairos-io/kairos#249

We also need to select the last item instead of the first here: https://github.com/kairos-io/kairos/blob/c141ea17923888c1b484fdbec09925c8b2febb26/internal/agent/upgrade.go#L54

and optionally show a prompt to the user to confirm the version before doing the ugprade (unless some cli flag is passed to confirm automatically)

@mudler maybe we should exclude "rc" versions and such (everything non-stable)?

[jimmykarily]

Tests fail. This looks relevant: golang/go#47979 (with a link to this)

[mudler]

Looking good!

[mudler]

Looking good! Also nice add with the filtering!

[jimmykarily]

The rest of the fix here: https://github.com/kairos-io/kairos/tree/249-choose-latest-version-on-upgrade

[mudler]

Looks good here! The failures are known ( #37 as a possible fix) and needs to be tackled separately

[jimmykarily]

I just realized the "stable" filtering is not working. I'm trying to figure out why the tests where green. Will open another PR with a fix.

[jimmykarily]

in semver, this is a pre-release v1.0.0-k3sv1.23.9-k3s1 even though it doesn't have an rc in it. I don't want to introduce any non-standard semver logic in our code and given we consider versions like the above to be stable, I think I'll just remove the filtering feature.
The alternative is to look for the rc string but that non-standard afaict.

[jimmykarily]

removed here: #82