Merge branch 'fix-154'

Backport actions#155

.github/dependabot.yml

@@ -10,5 +10,5 @@ updates:
     schedule:
       interval: daily
     ignore:
-      - dependency-name: '@types/*'
+      - dependency-name: '@types/node'
         update-types: ['version-update:semver-major']

__tests__/licenses.test.ts

@@ -122,3 +122,37 @@ test('it detects unknown licenses', async () => {
   })
   expect(unknownLicenses.sort()).toStrictEqual([nullLicense, unknownLicense])
 })
+
+test('it does not fail if a license outside the allow list is found in removed changes', async () => {
+  const changes: Changes = [
+    {...npmChange, change_type: 'removed'},
+    {...rubyChange, change_type: 'removed'}
+  ]
+  const [invalidChanges, _] = getDeniedLicenseChanges(changes, {
+    allow: ['BSD-2-Clause']
+  })
+  expect(invalidChanges).toStrictEqual([])
+})
+
+test('it does not fail if a license inside the deny list is found in removed changes', async () => {
+  const changes: Changes = [
+    {...npmChange, change_type: 'removed'},
+    {...rubyChange, change_type: 'removed'}
+  ]
+  const [invalidChanges, _] = getDeniedLicenseChanges(changes, {
+    deny: ['BSD-2-Clause']
+  })
+  expect(invalidChanges).toStrictEqual([])
+})
+
+test('it fails if a license outside the allow list is found in both of added and removed changes', async () => {
+  const changes: Changes = [
+    {...npmChange, change_type: 'removed'},
+    npmChange,
+    {...rubyChange, change_type: 'removed'}
+  ]
+  const [invalidChanges, _] = getDeniedLicenseChanges(changes, {
+    allow: ['BSD-2-Clause']
+  })
+  expect(invalidChanges).toStrictEqual([npmChange])
+})

src/licenses.ts

@@ -36,6 +36,10 @@ export function getDeniedLicenseChanges(
   const unknown: Change[] = []
 
   for (const change of changes) {
+    if (change.change_type === 'removed') {
+      continue
+    }
+
     const license = change.license
     if (license === null || !isSpdxId(license)) {
       unknown.push(change)