Skip to content

Commit

Permalink
fix: [Bug] Make lint command is not working (#1282)
Browse files Browse the repository at this point in the history
* fix: [Bug] Make lint command is not working

Signed-off-by: Milap Jhumkhawala <[email protected]>

* forgot to sign commit

Signed-off-by: Milap Jhumkhawala <[email protected]>

---------

Signed-off-by: Milap Jhumkhawala <[email protected]>
  • Loading branch information
milapj authored Oct 30, 2024
1 parent c128bf7 commit 87565a0
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ vet:
## lint: Run go lint against code.
.PHONY: lint
lint:
@golangci-lint run -v ./...
@golangci-lint run -v --timeout=5m ./...

## style: Code style -> fmt,vet,lint
.PHONY: style
Expand Down
2 changes: 1 addition & 1 deletion pkg/ai/azureopenai.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type AzureAIClient struct {
client *openai.Client
model string
temperature float32
organizationId string
// organizationId string
}

func (c *AzureAIClient) Configure(config IAIConfig) error {
Expand Down
2 changes: 1 addition & 1 deletion pkg/ai/openai.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type OpenAIClient struct {
model string
temperature float32
topP float32
organizationId string
// organizationId string
}

const (
Expand Down
1 change: 1 addition & 0 deletions pkg/custom/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ type Client struct {

func NewClient(c Connection) (*Client, error) {

//nolint:staticcheck // Ignoring SA1019 for compatibility reasons
conn, err := grpc.Dial(fmt.Sprintf("%s:%s", c.Url, c.Port), grpc.WithTransportCredentials(insecure.NewCredentials()))

if err != nil {
Expand Down
3 changes: 2 additions & 1 deletion pkg/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ import (
"net/http"
"strings"
"time"

//nolint:staticcheck // Ignoring SA1019 for compatibility reasons
gw2 "buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc-ecosystem/gateway/v2/schema/v1/server_analyzer_service/schemav1gateway"
//nolint:staticcheck // Ignoring SA1019 for compatibility reasons
gw "buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc-ecosystem/gateway/v2/schema/v1/server_config_service/schemav1gateway"
rpc "buf.build/gen/go/k8sgpt-ai/k8sgpt/grpc/go/schema/v1/schemav1grpc"
"github.com/go-logr/zapr"
Expand Down

0 comments on commit 87565a0

Please sign in to comment.