-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LSP to the Binder image #26
Conversation
In TypeScript - yes (already works if types are provided); in JS - I don't think it is possible with either |
Instead of babel we could try sucrase as in ipython/ipython#13376 - definitely worth experimenting. |
Hmm... I think figuring out a way to use the in-browser equivalent of On the broader point: the distribution of typings (or LSIF) should probably become a thing we by enable by default in e.g. Specifically on |
This now works (as in "the state is acceptable") but because the TypeScript filter expects the client to filter completions on their side we need to implement this to make it actually more useful; I opened jupyter-lsp/jupyterlab-lsp#728. |
Ok, going for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #24.
Binder: https://mybinder.org/v2/gh/krassowski/jupyterlab-plugin-playground/add-lsp?urlpath=lab
Note: we can hold this while I investigate migrating to a newer server (jupyter-lsp/jupyterlab-lsp#697) and we could improve the default theme of the completer so that the detail is shown below the label not next to it (so it is not as spread out).