Skip to content

Commit

Permalink
Remove the custom run keyboard shortcut (#6303)
Browse files Browse the repository at this point in the history
  • Loading branch information
jtpio authored Mar 9, 2022
1 parent 3e75f32 commit 4959617
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions packages/notebook-extension/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,28 +262,6 @@ const menuPlugin: JupyterFrontEndPlugin<void> = {
}
};

/**
* A plugin to add an extra shortcut to execute a cell in place via Cmd-Enter on Mac.
* TODO: switch to settings define menus when fixed upstream: https://github.com/jupyterlab/jupyterlab/issues/11754
*/
const runShortcut: JupyterFrontEndPlugin<void> = {
id: '@jupyter-notebook/notebook-extension:run-shortcut',
autoStart: true,
activate: (app: JupyterFrontEnd) => {
app.commands.addKeyBinding({
command: 'notebook:run-cell',
keys: ['Accel Enter'],
selector: '.jp-Notebook:focus'
});

app.commands.addKeyBinding({
command: 'notebook:run-cell',
keys: ['Accel Enter'],
selector: '.jp-Notebook.jp-mod-editMode'
});
}
};

/**
* A plugin to enable scrolling for outputs by default.
* Mimic the logic from the classic notebook, as found here:
Expand Down Expand Up @@ -381,7 +359,6 @@ const plugins: JupyterFrontEndPlugin<any>[] = [
kernelLogo,
kernelStatus,
menuPlugin,
runShortcut,
scrollOutput
];

Expand Down

0 comments on commit 4959617

Please sign in to comment.