Update jupyter_notebook_config.py to fix bug introduced in notebook 5.7.0

[jharris1679]

Latest release of notebook (5.7.0) introduces bug when c.NotebookApp.ip is set to '*'. See jupyter/notebook#3946 for details.

[parente]

notebook is still pinned to 5.6.* https://github.com/jupyter/docker-stacks/blob/master/base-notebook/Dockerfile#L90. Would you like to update that to 5.7.* in this PR too?

[jakirkham]

This still works with both versions right? So I guess this counts as future-proofing, which seems fine.

[jharris1679]

Hi, thanks. Hmm @parente I missed the fact that it's pinned to 5.6; I'm seeing evidence that the base notebook is picking up 5.7 and I had to change my Docker file to downgrade to 5.6. @jakirkham It doesn't seem to work on 5.7, see issue linked above.

Here's my Dockerfile

FROM jupyter/base-notebook

USER root

RUN apt-get -y update && \
    apt-get -y upgrade && \
    apt-get install -y --no-install-recommends build-essential && \
    apt-get install -y python-dev

RUN pip install wordcloud
RUN pip install gensim

USER jovyan

WORKDIR /home/jovyan

COPY payload/requirements.txt /home/jovyan/work

RUN pip install --requirement /home/jovyan/work/requirements.txt

RUN pip uninstall --yes notebook
RUN pip install notebook==5.6.0

COPY work /home/jovyan/
COPY . /home/jovyan/

CMD jt -t oceans16
CMD jupyter notebook

And the relevant output

Step 11/16 : RUN pip uninstall --yes notebook
 ---> Running in 5ae3467c4cfc
Uninstalling notebook-5.7.0:
  Successfully uninstalled notebook-5.7.0

I wondered if somehow notebook was being updated by apt-get but that doesn't seem to be the case. This Dockerfile is functioning well for me at the moment.

[jakirkham]

@jharris1679, I meant the change you proposed in this PR. 😉

[parente]

Let's We can update to Notebook 5.7 in another PR. Thanks @jharris1679 .