added convenience methods on output widget #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheilman
commented
Oct 12, 2017
| The object to display (e.g., an instance of | ||
| `IPython.display.Markdown` or `IPython.display.Image`). | ||
| """ | ||
| fmt = InteractiveShell.instance().display_formatter.format |
There was a problem hiding this comment.
This is based on this line in IPython.core.display.py. It seemed easier to follow how the display function works, where a user can pass, e.g., an Image object rather than asking users to provide the "raw" output format that this format function provides. If there's a better way to get this formatting functionality, let me know.
mheilman
force-pushed
the
append_output
branch
from
639bd75 to
55005a4
Compare
|
This looks good to me. Thanks! |
|
Ah great, thanks for this. |
|
Hopefully it will be released this afternoon. |
This was referenced Nov 8, 2017
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some convenience methods for adding output items to the Output widget in order to address #1724.
It also should make it easier to work around the apparent race condition discussed in #1722.