Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on ipyleaflet documentation #953

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

HaudinFlorence
Copy link
Contributor

use autodoc to replace the attributes and methods tables of the documentation by the autogeneration using docstrings
write the docstrings of velocity.Velocity class
add a page named API reference page for the leaflet module
add changes to homogenize the structure/names of the sections of the different pages

Fix #915

docs/res.txt Outdated Show resolved Hide resolved
docs/test.wkt Outdated Show resolved Hide resolved
ipyleaflet/leaflet.py Outdated Show resolved Hide resolved
res.txt Outdated Show resolved Hide resolved
@martinRenou
Copy link
Member

Thanks a lot! This is great.

The ReadTheDocs build fails because it's missing yarn, you should probably remove the requirements.txt file and replace it with and environment.yml file containing:

name: ipyleaflet-docs

channels:
  - conda-forge

dependencies:
  - yarn
  - jupyterlab
  - jupyter-packaging
  - jupyter-sphinx
  - scipy
  - netcdf4
  - geopandas
  - xarray
  - branca
  - shapely
  - pip:
    - .

@HaudinFlorence HaudinFlorence force-pushed the dev branch 2 times, most recently from 9ab90dd to e5d406d Compare April 1, 2022 14:16
@martinRenou
Copy link
Member

You will also need to change the readthedocs config file according to https://docs.readthedocs.io/en/latest/guides/conda.html#making-builds-faster-with-mamba in order to use mamba

@HaudinFlorence HaudinFlorence force-pushed the dev branch 5 times, most recently from 6dfaf26 to 7be3a90 Compare April 1, 2022 15:20
.readthedocs.yaml Outdated Show resolved Hide resolved
@HaudinFlorence HaudinFlorence force-pushed the dev branch 3 times, most recently from 774755b to 1d535d5 Compare April 1, 2022 16:14
use autodoc to replace the attributes and methods tables of the documentation by the autogeneration using docstrings
write the docstrings of velocity.Velocity class
add a page named API reference page for the leaflet module
add changes to homogenize the structure/names of the sections of the different pages
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great thanks!

@martinRenou martinRenou merged commit a54fbb4 into jupyter-widgets:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly use Sphinx for generating the API docs?
3 participants