-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bounds attribute to TileLayer #907
Add bounds attribute to TileLayer #907
Conversation
Not sure about the UI test failure, any idea @trungleduc ? |
You can update |
cfb2554
to
39d8a41
Compare
Thanks Trung, I uploaded the rendered snapshot. Let's hope the base map doesn't change too often. |
Thanks! You also need to change the Javascript model |
Thanks! Interestingly, it was already working without it. |
Yes, it's only used in some cases when the widget is embedded. |
@trungleduc where are the UI test assets uploaded? I cannot find them. |
https://github.com/jupyter-widgets/ipyleaflet/actions/runs/1605786157, Artifacts section |
I think we should update the |
56d0c5d
to
98effca
Compare
I removed the update of the rendered split map, tests are passing now. |
Did you see there was a very nice splitmap widget on Github for checking the splitmap screenshot? splitmap.mp4 |
e4d69ce
to
c0eb4b0
Compare
c0eb4b0
to
e6bce26
Compare
Closes #888