Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds attribute to TileLayer #907

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

davidbrochart
Copy link
Member

Closes #888

@davidbrochart
Copy link
Member Author

Not sure about the UI test failure, any idea @trungleduc ?

@trungleduc
Copy link
Contributor

it looks like some texts on the map have changed

  • Expected map
    SplitMapControl-expected

  • Rendered map
    SplitMapControl-actual

  • Diff

SplitMapControl-diff

@trungleduc
Copy link
Contributor

You can update SplitMapControl-linux.png file with the rendered map to make the tests pass, we can remove this test if the screenshot keeps changing.

@davidbrochart
Copy link
Member Author

Thanks Trung, I uploaded the rendered snapshot. Let's hope the base map doesn't change too often.

@martinRenou
Copy link
Member

Thanks! You also need to change the Javascript model

@davidbrochart
Copy link
Member Author

Thanks! Interestingly, it was already working without it.

@martinRenou
Copy link
Member

Yes, it's only used in some cases when the widget is embedded.

@davidbrochart
Copy link
Member Author

@trungleduc where are the UI test assets uploaded? I cannot find them.

@trungleduc
Copy link
Contributor

@trungleduc
Copy link
Contributor

I think we should update the SplitMapControl.ipynb notebook to move the map somewhere else

@davidbrochart
Copy link
Member Author

I removed the update of the rendered split map, tests are passing now.
I'm wondering if the tiles are not still loading when the snapshot is made, e.g. maybe we change the zoom and we don't wait enough?

@davidbrochart davidbrochart marked this pull request as draft December 21, 2021 08:51
@martinRenou
Copy link
Member

Did you see there was a very nice splitmap widget on Github for checking the splitmap screenshot?

splitmap.mp4

@davidbrochart davidbrochart force-pushed the tilelayer_bounds branch 2 times, most recently from e4d69ce to c0eb4b0 Compare December 21, 2021 09:44
@davidbrochart davidbrochart marked this pull request as ready for review December 21, 2021 10:27
@martinRenou martinRenou merged commit 3273696 into jupyter-widgets:master Dec 21, 2021
@davidbrochart davidbrochart deleted the tilelayer_bounds branch December 21, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constrain bounds of TileLayer
3 participants