Stop layer loading spinner when layer is removed #903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where if
show_loading
isTrue
for a layer, and this layer is removed from the map prior to all tiles being loaded, the loading spinner for this layer continues to spin and is stuck on the map indefinitely.It is noted that this tends to only be a problem for layers that take a good amount of time to load. Otherwise, under practical circumstances, it is unlikely that a layer
remove
event would fire before theload
event. Therefore, to reproduce the problem described above, you will either need to find a tile layer that is slow to load, or otherwise temporarily disable the bit of code that stops the loading spinner upon theload
event.(Also, this is my first contribution here! If I should be opening an issue or something like that, let me know!)