Support GeoJson layer in MarkerCluster #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangecoeur
changed the title
|
That's very neat! Thanks a lot! And thanks for using a view list, when looking at the code yesterday I thought we should do that. I will review more deeply and test it today 😊 |
|
Thanks! Would be great to have this enabled. |
martinRenou
reviewed
Nov 15, 2021
js/src/layers/MarkerCluster.js
Outdated
Comment on lines
47
to
48
| console.log(this.model.get('markers')); | ||
| console.log(child_model); |
There was a problem hiding this comment.
There are some leftover logs
Suggested change
| console.log(this.model.get('markers')); | |
| console.log(child_model); |
| @@ -0,0 +1,104 @@ | |||
| { | |||
There was a problem hiding this comment.
Could you clean the Notebook outputs?
|
Great thanks, just pushed a commit to remove console.log and clean the nb outputs. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR (needs review, maybe tests...) addessing #881
Made it possible to use a GeoJson layer as the data source for Marker Cluster, this makes it much faster when creating large numbers of markers (but not having bidirectional sync on individual Marker widgets).
Implemented by copying the behaviour of LayerGroup, it will simply attempt to add the model of whatever is provided in the marker list to the marker group: this allows to mix geojson and Marker elements.