Added found_style attribute for SearchControl #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yle if provided else the default style Signed-off-by: Kharude, Sachin <[email protected]>
…ments Signed-off-by: Kharude, Sachin <[email protected]>
martinRenou
requested changes
Jul 3, 2020
js/src/controls/SearchControl.js
Outdated
| @@ -18,6 +18,7 @@ export class LeafletSearchControlModel extends control.LeafletControlModel { | |||
| auto_collapse: false, | |||
| zoom:10, | |||
| animate_location:false, | |||
| found_style: {}, | |||
There was a problem hiding this comment.
The default value JavaScript side does not match the one Python side (this makes a difference when using embedded widgets)
…thon side Signed-off-by: Kharude, Sachin <[email protected]>
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kharude, Sachin [email protected]
Hi @martinRenou,
Added
found_styleattribute for SearchControl, now the user can specify his own style for the searched feature.Please review.