Implement __geo_interface__ for relevant classes #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
approved these changes
Jun 15, 2020
| @@ -545,6 +545,16 @@ def _get_data(self): | |||
|
|
|||
| return self.data | |||
|
|
|||
| @property | |||
| def __geo_interface__(self): | |||
| """ | |||
There was a problem hiding this comment.
Thanks for making a docstring! We need more of those.
|
Awesome @vpipkt ! |
|
@martinRenou Yes I would say it would be great for Marker and Polygon. Should I add to this PR or make a separate one? |
|
Another PR is fine :) Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
__geo_interface__spec forGeoJSON,Choropleth, andGeoData. ForGeoDatawe fall back togeopandasimplementation on theGeoDataFrame.Note that as is the convention with GeoDataFrame a
{'type': 'FeatureCollection', ...}can be returned. This is not explicitly stated in the spec but the comments lobby for it and ask the geopandas contributors to expand on their approach.This is my first contribution to the project so I appreciate your attention and patience!