Add pixel_bounds to Map #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it the size in pixels of the map? |
|
No, its bounds in pixels. |
|
In screen pixels? Is it the size of the map? |
|
Yes, screen pixels. You can get the size of the map from it. |
|
But that does not work when having multiple views with different sizes |
|
As for the bounds, we take the biggest view. |
|
I see :) ok |
martinRenou
reviewed
Jun 12, 2020
| @@ -1032,6 +1032,11 @@ def _default_options(self): | |||
| east = Float(def_loc[1], read_only=True).tag(sync=True) | |||
| west = Float(def_loc[1], read_only=True).tag(sync=True) | |||
|
|
|||
| bottom = Int(0, read_only=True).tag(sync=True) | |||
| top = Int(9007199254740991, read_only=True).tag(sync=True) | |||
There was a problem hiding this comment.
It's the biggest Number. We need this initial value in order to play well with the min.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
boundsread-only attribute, but in projected pixel coordinates instead of lat/lon coordinates (see https://leafletjs.com/reference-1.0.3.html#map-getpixelbounds).While
boundsis((south, west), (north, east)),pixel_boundsis((left, top), (right, bottom))to respect the Leaflet convention.