Changes to enable float zoom levels

[omanges]

These changes fix the issue raised in #591

[martinRenou]

LGTM! I can squash and merge.

[martinRenou]

The CI failure seems unrelated, but I am not sure

[martinRenou]

Yes it's unrelated. It might be a new flake8 rule. Let's fix it in another PR.

[davidbrochart]

zoom_delta and zoom_snap are not used on the JS side?

[martinRenou]

It is :) It will be auto-magically handled by ipyleaflet, being an option (o=True).

[davidbrochart]

Did you check that it works fine? I tried on a vector tile layer and it doesn't seem to work.

[omanges]

Yes, it is working for me. [image: image.png]

…

On Mon, Jun 1, 2020 at 12:57 PM David Brochart ***@***.***> wrote: Did you check that it works fine? I tried on a vector tile layer and it doesn't seem to work. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#608 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJU6TAAECARSCSRI6OEM7TRUNJ7NANCNFSM4NPGPIAA> .

[martinRenou]

Did you check that it works fine? I tried on a vector tile layer and it doesn't seem to work.

Actually you're right. Handling options changes is not implemented on the Map. This should be fixed.

We should have something like:

model_events() {
  let key;
  let options = this.model.get('options');
  for (var i = 0; i < o.length; i++) {
    key = options[i];
    this.listenTo(this.model, 'change:' + key, () => {
      L.setOptions(this.obj, this.get_options());
    }, this);
  }
}

In all base classes, we only have it in ControlView, not even in LayerView, which surprises me.

[davidbrochart]

@omanges it looks like it works for everything but a vector tile layer.

[davidbrochart]

My bad, I didn't pass the options on the Map but on the layer!
Everything's good, sorry!

[omanges]

Great, It works for you as well!!!

…

On Mon, Jun 1, 2020 at 1:22 PM David Brochart ***@***.***> wrote: My bad, I didn't pass the options on the Map but on the layer! Everything's good, sorry! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#608 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJU6THYH5ABJOWCTMJN633RUNM2BANCNFSM4NPGPIAA> .