Fix as_leaflet_layer #1037
Merged
Fix as_leaflet_layer #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to still be an issue in the docs though. |
|
My bad, the docs are fine locally. I'm going to revert the changes to the docs so that it's as in #1033 @banesullivan. |
davidbrochart
force-pushed
the
as_leaflet_layer
branch
from
41e46ea to
d197023
Compare
martinRenou
reviewed
Aug 11, 2022
| @@ -1172,8 +1172,6 @@ def add(self, layer): | |||
|
|
|||
| if isinstance(layer, dict): | |||
| layer = basemap_to_tiles(layer) | |||
| elif hasattr(layer, 'as_leaflet_layer'): | |||
There was a problem hiding this comment.
We should probably keep it here too though.
I wonder if we could implement remove and substitute too.
There was a problem hiding this comment.
Yes, let's do all that in follow-up PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1033.