Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing via m.layout.height = .. doesn't resize actual map #345

Closed
Kirill888 opened this issue May 3, 2019 · 6 comments
Closed

Resizing via m.layout.height = .. doesn't resize actual map #345

Kirill888 opened this issue May 3, 2019 · 6 comments
Labels

Comments

@Kirill888
Copy link
Contributor

Enclosing container for leaflet map remains always at 400px

I believe this is due to this css rule (line 2):

.jupyter-widgets > .leaflet-container {
height: 400px;
overflow: hidden;
flex: 1 1 auto;
}

This is on master branch.

@martinRenou
Copy link
Member

Is the behavior on master different from the last release?

@Kirill888
Copy link
Contributor Author

I think it was changing size correctly before I switched to master.
I think solution is to use 100% instead of 400px

@martinRenou
Copy link
Member

Thanks for looking at it and for reporting the issue!

There were some recent changes on the layout, so it is possible that master is broken. Also, we need to check that ipyleaflet still works fine using a side-pane view or jupyterlab-sidecar, those features might also be broken.

@Kirill888
Copy link
Contributor Author

But then you have to set default height via usual widget layout mechanisms, otherwise you get empty maps within HBox/VBox

@martinRenou martinRenou added the Bug label May 3, 2019
Kirill888 added a commit to Kirill888/ipyleaflet that referenced this issue May 4, 2019
Copy height from parent widget div into map div, addresses issue jupyter-widgets#345
@martinRenou
Copy link
Member

This should be fixed on current master

@AndrewAnnex
Copy link

AndrewAnnex commented Apr 26, 2021

I am seeing this issue with 0.13.6, although I have a complicated jupyterlab/conda setup that maybe interfering. if other jupyter installs and conda environments should not matter then something is wrong

edit nevermind, it now works even though I didn't change the syntax of my usage at all. not sure why it wasn't working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants