Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pagination in AdvancedTable #239

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix pagination in AdvancedTable #239

merged 1 commit into from
Nov 1, 2022

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Oct 31, 2022 •
edited
Loading

Pagination was broken by #212, as the list of rendered rows would not be updated after changing the page.

@dlqqq dlqqq added the bug Something isn't working label Oct 31, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch dlqqq/jupyter-scheduler/table-pagination-fix

@dlqqq dlqqq mentioned this pull request Oct 31, 2022
Open
@dlqqq dlqqq changed the title add page as a dependency to renderedRows fix pagination in AdvancedTable Oct 31, 2022
andrii-i
andrii-i approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug

@dlqqq dlqqq merged commit 20b9903 into jupyter-server:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-i andrii-i andrii-i approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlqqq @andrii-i