-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select all output formats by default #198
Merged
andrii-i
merged 8 commits into
jupyter-server:main
from
andrii-i:default-select-all-output-formats
Oct 25, 2022
Merged
Select all output formats by default #198
andrii-i
merged 8 commits into
jupyter-server:main
from
andrii-i:default-select-all-output-formats
Oct 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-i
force-pushed
the
default-select-all-output-formats
branch
from
October 25, 2022 16:53
27282c2
to
f4a21d2
Compare
andrii-i
changed the title
Support job creation with no output formats chosen, default select all output formats
Default select all output formats
Oct 25, 2022
andrii-i
changed the title
Default select all output formats
Select all output formats by default
Oct 25, 2022
dlqqq
requested changes
Oct 25, 2022
Updated preview in the PR description |
dlqqq
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love how much shorter the diff is after your revisions. Looks great 👍
I'm particularly happy that if-else branching in useEffect is not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Takes care of "select all output formats by default" part of #196
"Allow for selection of no formats" would be taken care of in a separate PR
Preview