Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all output formats by default #198

Merged

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Oct 24, 2022

Description

Takes care of "select all output formats by default" part of #196
"Allow for selection of no formats" would be taken care of in a separate PR

Preview

out_form

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch andrii-i/jupyter-scheduler/default-select-all-output-formats

@andrii-i andrii-i added the enhancement New feature or request label Oct 24, 2022
@andrii-i andrii-i force-pushed the default-select-all-output-formats branch from 27282c2 to f4a21d2 Compare October 25, 2022 16:53
@andrii-i andrii-i changed the title Support job creation with no output formats chosen, default select all output formats Default select all output formats Oct 25, 2022
@andrii-i andrii-i changed the title Default select all output formats Select all output formats by default Oct 25, 2022
src/mainviews/create-job.tsx Outdated Show resolved Hide resolved
src/mainviews/create-job.tsx Outdated Show resolved Hide resolved
src/mainviews/create-job.tsx Show resolved Hide resolved
@andrii-i andrii-i requested a review from dlqqq October 25, 2022 21:25
@andrii-i
Copy link
Collaborator Author

Updated preview in the PR description

Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how much shorter the diff is after your revisions. Looks great 👍

@andrii-i
Copy link
Collaborator Author

I'm particularly happy that if-else branching in useEffect is not necessary

@andrii-i andrii-i merged commit d95c64e into jupyter-server:main Oct 25, 2022
@andrii-i andrii-i deleted the default-select-all-output-formats branch October 25, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants