fix schedule validation errors not clearing after selecting run now (#…

…261)
jupyter-server · Nov 2, 2022 · 77570d8 · 77570d8
1 parent f1afc63
commit 77570d8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/src/components/create-schedule-options.tsx b/src/components/create-schedule-options.tsx
@@ -36,20 +36,26 @@ export function CreateScheduleOptions(
     // so that in case there's an error with the schedule,
     // the form can still be submitted.
     if (value === 'Job') {
-      // Change from 'JobDefinition'
+      // Change from 'JobDefinition' and clear all job definition specific errors
       props.handleErrorsChange({
         ...props.errors,
-        schedule: ''
+        schedule: '',
+        scheduleInterval: '',
+        timezone: '',
+        scheduleHourMinute: '',
+        scheduleMinute: '',
+        scheduleHour: '',
+        scheduleMonthDay: '',
+        scheduleWeekDay: '',
+        scheduleTime: ''
       });
     }
-    if (value === 'JobDefinition') {
+    if (value === 'JobDefinition' && props.model.schedule) {
       // If the schedule is not populated, don't display an error for now.
-      if (props.model.schedule) {
-        props.handleErrorsChange({
-          ...props.errors,
-          schedule: validator.validateSchedule(props.model.schedule)
-        });
-      }
+      props.handleErrorsChange({
+        ...props.errors,
+        schedule: validator.validateSchedule(props.model.schedule)
+      });
     }
 
     props.handleModelChange({ ...props.model, [name]: value });

diff --git a/src/model.ts b/src/model.ts
@@ -51,6 +51,7 @@ export type ModelWithScheduleFields = {
   scheduleMonthDayInput?: string;
   scheduleMonthDay?: number;
   scheduleWeekDay?: string;
+  scheduleTime?: number;
 };
 
 export interface ICreateJobModel