feat: note on drop

juanfran · Dec 17, 2024 · 8b297de · 8b297de
1 parent 5ae10b4
commit 8b297de
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 16 deletions.
diff --git a/apps/web/src/app/services/board-facade.service.ts b/apps/web/src/app/services/board-facade.service.ts
@@ -92,22 +92,26 @@ export class BoardFacade {
   }
   selectCursors() {
     return this.getUsers().pipe(
-      concatLatestFrom(() => [this.store.select(pageFeature.selectUserId), this.store.select(pageFeature.selectBoardUsers)]),
+      concatLatestFrom(() => [
+        this.store.select(pageFeature.selectUserId),
+        this.store.select(pageFeature.selectBoardUsers),
+      ]),
       map(([users, currentUser, boardUsers]) => {
-        console.log('users board facade', users);
-        return users.filter((user) => {
-          return (
-            !!user.content.cursor &&
-            user.content.connected &&
-            user.id !== currentUser
-          );
-        }).map((user) => {
-          const boardUser = boardUsers.find((bu) => bu.id === user.id);
-          return {
-            ...user.content,
-            picture: boardUser?.picture
-          };
-        });
+        return users
+          .filter((user) => {
+            return (
+              !!user.content.cursor &&
+              user.content.connected &&
+              user.id !== currentUser
+            );
+          })
+          .map((user) => {
+            const boardUser = boardUsers.find((bu) => bu.id === user.id);
+            return {
+              ...user.content,
+              picture: boardUser?.picture,
+            };
+          });
       }),
     );
   }

diff --git a/libs/cdk/src/lib/services/multi-drag.service.ts b/libs/cdk/src/lib/services/multi-drag.service.ts
@@ -22,6 +22,7 @@ export interface Draggable {
   destroyRef: DestroyRef;
   position: () => Point;
   preventDrag?: () => boolean;
+  drop?: () => void;
 }
 
 interface SetupConfig {
@@ -277,6 +278,8 @@ export class MultiDragService {
           initialIndex: dragElement.initialIndex,
           finalPosition: dragElement.final,
         });
+
+        dragElement.draggable.drop?.();
       }
     });
 

diff --git a/libs/nodes/src/lib/node-space/node-space.component.ts b/libs/nodes/src/lib/node-space/node-space.component.ts
@@ -7,6 +7,7 @@ import {
   ViewChild,
   computed,
   inject,
+  output,
 } from '@angular/core';
 import { Point, Resizable, Rotatable, TuNode } from '@tapiz/board-commons';
 import { MultiDragService } from '@tapiz/cdk/services/multi-drag.service';
@@ -78,6 +79,7 @@ export class NodeSpaceComponent implements AfterViewInit {
   resize = input(false);
   rotate = input(false);
   cursor = input('grab');
+  drop = output();
 
   @ViewChild('drag')
   drag!: ElementRef<HTMLElement>;
@@ -118,6 +120,9 @@ export class NodeSpaceComponent implements AfterViewInit {
       preventDrag: () => this.preventDrag,
       position: () => this.position,
       destroyRef: this.#destroyRef,
+      drop: () => {
+        this.drop.emit();
+      },
     });
   }
 }
diff --git a/libs/nodes/src/lib/note/note.component.html b/libs/nodes/src/lib/note/note.component.html
@@ -3,7 +3,8 @@
   [resize]="true"
   [rotate]="false"
   [enabled]="!edit() && focus()"
-  [cursor]="cursor()">
+  [cursor]="cursor()"
+  (drop)="onDrop()">
   <div class="inner">
     <div class="top-info">
       @if (comments()) {

diff --git a/libs/nodes/src/lib/note/note.component.ts b/libs/nodes/src/lib/note/note.component.ts
@@ -529,4 +529,8 @@ export class NoteComponent {
       );
     }
   }
+
+  onDrop() {
+    // pass
+  }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -529,4 +529,8 @@ export class NoteComponent { @@
           );
         }
       }
+      onDrop() {
+        // pass
+      }
     }