Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot.xts doesn't plot more than 8 columns properly on multi.panel = T #423

Closed
ethanbsmith opened this issue Jul 28, 2024 · 2 comments · Fixed by #424
Closed

plot.xts doesn't plot more than 8 columns properly on multi.panel = T #423

ethanbsmith opened this issue Jul 28, 2024 · 2 comments · Fixed by #424
Labels
bug plot
Milestone
0.14.1

Comments

@ethanbsmith
Copy link
Contributor

ethanbsmith commented Jul 28, 2024 •
edited by joshuaulrich
Loading

Description

when plotting more than 8 columns in multi.panel, the last columns dont display
this is because plot.xts defaults col = 1:8

Expected behavior

default should handle any number of columns properly, either recycling the colors after 8, or defaulting col = 1:ncol(x)

Minimal, reproducible example

This code doesn't plot the lines on the last 2 panels because there's no 'col' value for them by default.

d <- xts(matrix(1:100, ncol = 10), order.by = Sys.Date() + (1:10))
plot(d, multi.panel = T)

image

Session Info

R version 4.4.0 (2024-04-24 ucrt)
Platform: x86_64-w64-mingw32/x64
Running under: Windows 11 x64 (build 22631)

Matrix products: default


locale:
[1] LC_COLLATE=English_United States.utf8  LC_CTYPE=English_United States.utf8    LC_MONETARY=English_United States.utf8 LC_NUMERIC=C                          
[5] LC_TIME=English_United States.utf8    

time zone: America/Denver
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] xts_0.14.1 zoo_1.8-12

loaded via a namespace (and not attached):
[1] compiler_4.4.0 grid_4.4.0     lattice_0.22-6
@joshuaulrich
Copy link
Owner

This should be straightforward to fix. Want to give it a shot? It might be as easy as setting the default col = 1:nrow(x).

Is it also an issue for a single plot of an object with more than 8 columns?

@ethanbsmith
Copy link
Contributor Author

multi.panel = F looks like it recycles col values.
chart.lines handles recycling via: if(length(col) < NCOL(x)) col <- rep(col, length.out = NCOL(x))

I can work on a pr to move that check earlier in the flow

@ethanbsmith ethanbsmith mentioned this issue Jul 28, 2024
Merged
joshuaulrich pushed a commit that referenced this issue Aug 6, 2024
@ethanbsmith
Ensure col, lty, and lwd have ncol(x) elements
3086e14 
When 'x' has more than 8 columns and multi.panel = TRUE, columns 9 and
later don't render because of the default 'col = 1:8'. Thanks to Ethan
Smith for the report and patch.

Fixes #423
@joshuaulrich joshuaulrich added this to the 0.14.1 milestone Aug 6, 2024
@ethanbsmith ethanbsmith mentioned this issue Nov 1, 2024
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 24, 2024
(math/R-xts) Updated 0.13.1 to 0.14.1
3e167f0 
# xts 0.14.x (202x-xx-xx)

* `plot.xts()` now renders all panels when 'x' has more than 8 columns and
  `multi.panel = TRUE`. Columns 9 and later didn't render because the default
  of `plot.xts()` is 'col = 1:8'. Thanks to Ethan Smith for the report and
  patch.
  ([#423](joshuaulrich/xts#423))
  ([#424](joshuaulrich/xts#424))

* `plot.xts()` no longer errors when 'ylim' is constant and negative. Thanks
  to Ethan Smith for the report.
  ([#422](joshuaulrich/xts#422))

* Do not use `SET_TYPEOF()` in C because it is not part of the public R API.

* `merge.xts()` no longer converts 'x' or 'y' from double to integer in the C
  code when they are not used in the result. This avoids an unnecessary and
  confusing warning. Thanks to Jeff Ryan for the report.

# xts 0.14.0 (2024-06-05)

* `addEventLines()` and `addLegend()` now draw on multiple panels when `on` is
  a vector. Thanks to Ethan Smith for the report.
  ([#420](joshuaulrich/xts#420))

* Replace `SET_TYPEOF()` in merge.c because it will error when it tries to
  convert a REAL to an INTEGER. Thanks to Kurt Hornik for the report!
  ([#419](joshuaulrich/xts#419))

* Fix crash when 'j' is not an integer and in [0, 1) (e.g. `j = 0.1`). Also
  throw a warning when 'j' is not an integer.
  ([#413](joshuaulrich/xts#413))
  ([#415](joshuaulrich/xts#415))

* Fix plot header when `layout()` is used to draw multiple plots on a single
  device. Thanks to Dirk Eddelbuettel for the report and testing!
  ([#412](joshuaulrich/xts#412))

* Fix plot legend location when the y-axis is log scale.
  ([#407](joshuaulrich/xts#407))

# xts 0.13.2 (2024-01-21)

* Print a message when `period.apply()` is called with `FUN = mean` because it
  calculates the mean for each column, not all the data in the subset like it
  does for all other functions. The message says to use `FUN = colMeans` for
  current behavior and `FUN = function(x) mean(x)` to calculate the mean for
  all the data. This information is also included in the help files. The option
  `xts.message.period.apply.mean = FALSE` suppresses the message.
  ([#124](joshuaulrich/xts#124))

* Fix error when `print.xts()` is called 'quote' or 'right' arguments.
  ([#401](joshuaulrich/xts#401))

* Fix `addPolygon()` so it renders when `observation.based = TRUE`.
  ([#403](joshuaulrich/xts#403))

* Print trailing zeros for index value with fractional seconds, so every index
  value has the same number of characters.
  ([#404](joshuaulrich/xts#404))

* Add ability to log scale the y-axis in `plot.xts()`.
  ([#103](joshuaulrich/xts#103))

* Actually change the underlying index values when 'tclass' is changed from a
  class with a timezone (e.g. POSIXct) to one without a timezone (e.g. Date).
  Add a warning when this happens, with a global option to always suppress the
  warning.
  ([#311](joshuaulrich/xts#311)).

* Significantly refactor the internals of `plot.xts()`.
  ([#408](joshuaulrich/xts#408))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug plot
Projects
None yet
Milestone
0.14.1
Development

Successfully merging a pull request may close this issue.

moved col length checks to cover multi.panel = T as well as being num… ethanbsmith/xts
2 participants
@joshuaulrich @ethanbsmith