Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is pool.terminate async? #56

Closed
mramato opened this issue Mar 9, 2019 · 2 comments
Closed

Is pool.terminate async? #56

mramato opened this issue Mar 9, 2019 · 2 comments

Comments

@mramato
Copy link

mramato commented Mar 9, 2019

The documentation treats pool.terminate as synchronous, but in practice (at least under Node.js) it returns a Promise.

It makes sense to me that it would be asynchronous, but I wanted to confirm before updating my own code.

If it is async, I'd be happy to open a PR to make sure the doc matches.

Thanks for an awesome library!
@josdejong
Copy link
Owner

@mramato thanks, you're right. The terminate method returns a promise but this is not documented anywhere. A PR to improve the docs would be welcome!

@mramato
Copy link
Author

mramato commented Mar 10, 2019

Thanks, will do.

mramato added a commit to mramato/workerpool that referenced this issue Mar 10, 2019
@mramato
Update documentation and examples for pool.terminate.
c01a81a 
`pool.terminuate` returns a Promise, but the documentation and examples
treated it as if it were synchronous.

Fixes josdejong#56
@mramato mramato mentioned this issue Mar 10, 2019
Open
maybephilipp pushed a commit to maybephilipp/workerpool that referenced this issue Sep 27, 2020
@anzud @starostin13
Products table showed josdejong#19 (josdejong#56)
7038ed8 
* Add scenario

* extra spaces

* expand uploadFile for specify different files

* change action for use fieName

* too early try to upload file

* trying to fix login unstability

Co-authored-by: Aleksey Gerasimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josdejong @mramato