Fix issues with transpositions on GPUs #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 97.01% 96.97% -0.04%
==========================================
Files 22 22
Lines 1208 1192 -16
==========================================
- Hits 1172 1156 -16
Misses 36 36
Continue to review full report at Codecov.
|
They don't play well with CuArrays. Moreover, the conversion of a CuPtr to a MPIPtr is not exposed by MPI.jl (unlike the case of CuArray views).
Previously, when calling `gather` on GPU arrays, MPI was sending GPU data and receiving CPU data. We now convert to CPU arrays before passing the data to MPI, so that all communications are done on the CPU.
jipolanco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues when transposing distributed CuArrays:
CuPtrsgathersometimes gave wrong results on distributedCuArrays