Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUtils: fix readline in classpath #608

Merged

Conversation

pascalgrimaud
Copy link
Member

@pascalgrimaud pascalgrimaud commented Jan 28, 2022

It's probably the reason why #596 failed

@DanielFran : once it's merged, can you rebase with this fix plz?

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #608 (bef1e96) into main (aaf5338) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #608   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       963       966    +3     
===========================================
  Files            175       175           
  Lines           2953      2965   +12     
  Branches          60        62    +2     
===========================================
+ Hits            2953      2965   +12     
Impacted Files Coverage Δ
...va/tech/jhipster/lite/common/domain/FileUtils.java 100.00% <100.00%> (ø)
...tor/buildtool/maven/domain/MavenDomainService.java 100.00% <100.00%> (ø)
...or/packagemanager/npm/domain/NpmDomainService.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf5338...bef1e96. Read the comment docs.

@pascalgrimaud pascalgrimaud merged commit 462303d into jhipster:main Jan 28, 2022
@DanielFran
Copy link
Member

@pascalgrimaud I was a little blocked because buildtool was not identifying process as a maven project... but did not have time to check the origin of this issue.
Will confirm if that was the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants