Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot Common: code smells, define constant #544

Merged

Conversation

pascalgrimaud
Copy link
Member

@pascalgrimaud pascalgrimaud commented Jan 17, 2022

Following #540

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #544 (ae730f3) into main (b9f4028) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #544   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       877       877           
===========================================
  Files            160       160           
  Lines           2665      2668    +3     
  Branches          57        57           
===========================================
+ Hits            2665      2668    +3     
Impacted Files Coverage Δ
...t/common/domain/SpringBootCommonDomainService.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f4028...ae730f3. Read the comment docs.

@pascalgrimaud pascalgrimaud merged commit dbba2f5 into jhipster:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant