Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sign commit for generation (not so useful) #402

Merged
merged 1 commit into from
Dec 24, 2021

Conversation

hdurix
Copy link
Member

@hdurix hdurix commented Dec 24, 2021

Fix #147

@CLAassistant
Copy link

CLAassistant commented Dec 24, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #402 (4429b71) into main (d6d2308) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #402   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       597       597           
===========================================
  Files            102       102           
  Lines           1888      1888           
  Branches          38        38           
===========================================
  Hits            1888      1888           
Impacted Files Coverage Δ
...tor/project/infrastructure/secondary/GitUtils.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d2308...4429b71. Read the comment docs.

@pascalgrimaud pascalgrimaud merged commit 5ba7dd3 into jhipster:main Dec 24, 2021
@pascalgrimaud
Copy link
Member

Thanks a lot @hdurix !!!

@hdurix hdurix deleted the do-not-sign-commit branch April 21, 2022 08:37
@hdurix
Copy link
Member Author

hdurix commented Aug 4, 2022

@pascalgrimaud
Copy link
Member

@hdurix : approved

@hdurix hdurix mentioned this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitUtilsTest failure for signing commits
3 participants