Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code #11328

Merged
merged 6 commits into from
Nov 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ assertion-error.STRING_TOO_SHORT.title=String too short
assertion-error.STRING_WITH_WHITESPACES.detail=The string {{ field }} must not have any whitespaces
assertion-error.STRING_WITH_WHITESPACES.title=String with whitespaces

assertion-error.TOO_MANY_ELEMENTS.detail=There is too many elements in {{ field }}, max is {{ maxSize }} (current {{ currentSize }} element(s))
assertion-error.TOO_MANY_ELEMENTS.detail=There are too many elements in {{ field }}, max is {{ maxSize }} (current {{ currentSize }} element(s))
assertion-error.TOO_MANY_ELEMENTS.title=Too many elements
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
################################# Messages for errors #################################
#######################################################################################

error.bad-request.detail=Votre requête n'est pas valide: {{ code }}
error.bad-request.detail=Votre requête n'est pas valide : {{ code }}
error.bad-request.title=Bad request

error.internal-server-error.detail=Une erreur est survenue
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ class {{ baseName }}ErrorsHandlerIT {
.perform(get("/api/errors/bad-request").locale(Locale.FRANCE))
.andExpect(status().is4xxClientError())
.andExpect(jsonPath("title").value("Bad request"))
.andExpect(jsonPath("detail").value("Votre requête n'est pas valide: 400"));
.andExpect(jsonPath("detail").value("Votre requête n'est pas valide : 400"));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class AssertionErrorsHandlerIT {
.perform(get("/api/assertion-errors/too-many-elements"))
.andExpect(status().isBadRequest())
.andExpect(jsonPath("title").value("Too many elements"))
.andExpect(jsonPath("detail").value("There is too many elements in myField, max is 1 (current 2 element(s))"))
.andExpect(jsonPath("detail").value("There are too many elements in myField, max is 1 (current 2 element(s))"))
.andExpect(jsonPath("key").value("TOO_MANY_ELEMENTS"));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {{packageName}}.account.infrastructure.primary.RestAuthenticationQuery.Re
import {{packageName}}.shared.authentication.domain.Roles;

@JsonDeserialize(builder = RestAuthenticationQueryBuilder.class)
@Schema(name = "AuthenticationQuery", description = "Query to authenticate au user")
@Schema(name = "AuthenticationQuery", description = "Query to authenticate a user")
final class RestAuthenticationQuery {

private final String username;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1807,7 +1807,7 @@
{
"id": "da7d3a39-7077-4354-9ffc-5b9f79fbaf0d",
"alias": "Verify Existing Account by Re-authentication",
"description": "Reauthentication of existing account",
"description": "Re-authentication of existing account",
"providerId": "basic-flow",
"topLevel": false,
"builtIn": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ assertion-error.STRING_TOO_SHORT.title=String too short
assertion-error.STRING_WITH_WHITESPACES.detail=The string {{ field }} must not have any whitespaces
assertion-error.STRING_WITH_WHITESPACES.title=String with whitespaces

assertion-error.TOO_MANY_ELEMENTS.detail=There is too many elements in {{ field }}, max is {{ maxSize }} (current {{ currentSize }} element(s))
assertion-error.TOO_MANY_ELEMENTS.detail=There are too many elements in {{ field }}, max is {{ maxSize }} (current {{ currentSize }} element(s))
assertion-error.TOO_MANY_ELEMENTS.title=Too many elements

assertion-error.STRING_NOT_MATCHING_PATTERN.detail=The string {{ field }} must match the pattern {{ pattern }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ void shouldHandleTooManyElements() throws Exception {
.perform(get("/api/assertion-errors/too-many-elements"))
.andExpect(status().isBadRequest())
.andExpect(jsonPath("title").value("Too many elements"))
.andExpect(jsonPath("detail").value("There is too many elements in myField, max is 1 (current 2 element(s))"))
.andExpect(jsonPath("detail").value("There are too many elements in myField, max is 1 (current 2 element(s))"))
.andExpect(jsonPath("key").value("TOO_MANY_ELEMENTS"));
}

Expand Down
Loading