Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vuejwtapp and vueoauth2app at the matrix in github-actions.yml #11088

Conversation

renanfranca
Copy link
Contributor

Fix #897 (roadmap at description)

@renanfranca
Copy link
Contributor Author

@pascalgrimaud, @murdos: I removed vueapp and created vuejwtapp and vueoauth2app because the modules vue-jwt and vue-oauth2-keycloak have files with the same names, and both couldn't be applied in the same app in generate.sh.

Copy link
Contributor

@murdos murdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!
@pascalgrimaud : do you have some reluctance to add more generated apps in ci?

@pascalgrimaud
Copy link
Member

@murdos : no, we can add new CI for testing new modules. If I remember well, there should be a check with md5sum or something like that. If the md5sum doesn't change, this job will stop, so in the end, we won't lost lot of time

@pascalgrimaud pascalgrimaud merged commit 9450e0b into jhipster:main Oct 11, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue: account with authentication JWT
3 participants