rework react core like vue core #11010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdos
added
area: feature request 💡
client: react
area: breaking change
and removed
area: triage
labels
murdos
previously approved these changes
Sep 29, 2024
|
Looks fine. |
DamnClin
reviewed
Sep 29, 2024
fabienpuissant
force-pushed
the
rework-react-core
branch
4 times, most recently
from
7c4a203 to
d370355
Compare
fabienpuissant
force-pushed
the
rework-react-core
branch
from
d370355 to
28bde5b
Compare
DamnClin
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to rework react i18n module, it would be nice to rework the react core module like @DamnClin did for vue core module
Because translation typescript files will be shared between react and vue
=> home context with the component into the primary infrastructure
Obviously impacting react-i18n and react-jwt module
Prerequisites to #11002