Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue: add tests for AxiosHttp #10824

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Vue: add tests for AxiosHttp #10824

merged 1 commit into from
Sep 14, 2024

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Sep 13, 2024 •
edited
Loading

Related to #10822

image

@qmonmert qmonmert added area: bug 🐛 Something isn't working client: vue labels Sep 13, 2024
@murdos
Copy link
Contributor

murdos commented Sep 13, 2024

My feeling was that we should exclude this code from code coverage computation rather than adding tests to cover it.

@qmonmert
Copy link
Contributor Author

But these tests are presents in the generator

@pascalgrimaud
Copy link
Member

I agree with you @murdos

But as these tests already exist, we can simply keep them, and put back the coverage to 100% in vitest config

Then, later, in another PR:

  • exclude these files properly
  • keep consistency between jhlite and generated app

@pascalgrimaud pascalgrimaud merged commit b825bb2 into jhipster:main Sep 14, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

Assignees
No one assigned
Labels
area: bug 🐛 Something isn't working client: vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qmonmert @murdos @pascalgrimaud