Rework vue-core

[DamnClin]

No description provided.

[DamnClin]

The build is failing because I removed all tests because they were implementation details test. This is failing on npm run test:coverage don't find any test.

I don't know if I add a dummy test or change the target. Any input are welcome here :)

[DamnClin]

Discussion today: maybe replace this by threshold only for domain

[DamnClin]

Afterthoughts: not a good idea since some front domain models will just be types validated by component tests

[pascalgrimaud]

I'm a little bit late on this, we should improve this part, and only include what we want
I created this ticket #10822

[renanfranca]

I don't know if I add a dummy test or change the target. Any input are welcome here :)

@DamnClin : Could it be a home route test?

[renanfranca]

@DamnClin : after this redesign got merged. Can you tell me if is it going to be a AxiosHttp module for each client (angular, vue, react)?

[DamnClin]

I don't know if I add a dummy test or change the target. Any input are welcome here :)

@DamnClin : Could it be a home route test?

@renanfranca I'm strongly agains route test since this is an implementation detail test

[DamnClin]

@DamnClin : after this redesign got merged. Can you tell me if is it going to be a AxiosHttp module for each client (angular, vue, react)?

Can be a good idea to have the same AxiosHttp module for every clients yes

[renanfranca]

I don't know if I add a dummy test or change the target. Any input are welcome here :)

@DamnClin : Could it be a home route test?

@renanfranca I'm strongly agains route test since this is an implementation detail test

So dummy test is fine 🙂

[DamnClin]

cc @Gnuk @murdos @pascalgrimaud what do you think of this version?

[renanfranca]

@DamnClin: I have already applied these changes to add the vue-core module to implement a sample that will be used to fix Vue: add OAuth2 keycloak authentication. Everything went well! Can you explain why you chose not to add the AxiosHttps stubs and tests? I think a well-implemented test would help guide those who use that module. Anyway, thank you for your work!

[DamnClin]

@DamnClin: I have already applied these changes to add the vue-core module to implement a sample that will be used to fix Vue: add OAuth2 keycloak authentication. Everything went well! Can you explain why you chose not to add the AxiosHttps stubs and tests? I think a well-implemented test would help guide those who use that module. Anyway, thank you for your work!

As it is, for me, this is testing an implementation detail

[pascalgrimaud]

I'm adding a big bounty on this, as it was a lot of work here.
Don't forget to claim it @DamnClin

[DamnClin]

I'm adding a big bounty on this, as it was a lot of work here. Don't forget to claim it @DamnClin

Thanks a lot, claimed #10712 (comment)

[pascalgrimaud]

@DamnClin : the link is not correct :-D

[DamnClin]

@DamnClin : the link is not correct :-D

Sorry, misslick in github... https://opencollective.com/generator-jhipster/expenses/220095

[pascalgrimaud]

@DamnClin : approved, thanks a lot for your work