Fix: preset modules selected and deselected #10663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanfranca
previously approved these changes
Aug 24, 2024
Comment on lines
+414
to
+419
| landscapeValue() | ||
| .selectedModules() | ||
| .forEach(module => { | ||
| landscape.value.loaded(landscapeValue().toggle(module)); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@qmonmert, if you could create a test for this, it would be really nice 👌
There was a problem hiding this comment.
yes, there should be a test to prove our initial code was with a bug
renanfranca
approved these changes
Aug 24, 2024
Comment on lines
+1122
to
+1137
| it('should select modules from selected preset when preset option is updated multiple times', async () => { | ||
| let { initModuleElement } = await setupAndSelectPreset('init-prettier'); | ||
|
|
||
| let classes = initModuleElement.classes(); | ||
| ['-selected', '-compacted'].forEach(expectedClass => { | ||
| expect(classes).toContain(expectedClass); | ||
| }); | ||
|
|
||
| ({ initModuleElement } = await setupAndSelectPreset('init-typescript')); | ||
|
|
||
| classes = initModuleElement.classes(); | ||
| ['-selected', '-compacted'].forEach(expectedClass => { | ||
| expect(classes).toContain(expectedClass); | ||
| }); | ||
| }); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10660