Merge pull request #10760 from qmonmert/reacteslint2

React/ESLint: enable some rules
jhipster · Sep 4, 2024 · 7f438c1 · 7f438c1
2 parents 05dc745 + 4722cf1
commit 7f438c1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/main/resources/generator/client/react/core/eslint.config.js.mustache b/src/main/resources/generator/client/react/core/eslint.config.js.mustache
@@ -33,10 +33,12 @@ export default typescript.config(
     },
     rules: {
       'react/react-in-jsx-scope': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-floating-promises': 'off',
-      '@typescript-eslint/no-misused-promises': 'off',
+      '@typescript-eslint/no-misused-promises': [
+        'error',
+        {
+          'checksVoidReturn': false
+        }
+      ],
     },
   },
 );
diff --git a/...client/react/security/jwt/src/main/webapp/app/login/primary/loginModal/index.tsx.mustache b/...client/react/security/jwt/src/main/webapp/app/login/primary/loginModal/index.tsx.mustache
@@ -20,9 +20,9 @@ const LoginModal = ({ open, onClose }: LoginModalType) => {
 
   const toggleVisibility = () => setIsVisible(!isVisible);
 
-  const onSubmit = (loginData: LoginFunctionType) => {
+  const onSubmit = async (loginData: LoginFunctionType) => {
     if (loginData.username && loginData.password) {
-      login({ ...loginData, setUsername, setToken });
+      await login({ ...loginData, setUsername, setToken });
       setError(false);
       onClose();
     } else {

diff --git a/.../generator/client/react/security/jwt/src/main/webapp/app/login/services/login.ts.mustache b/.../generator/client/react/security/jwt/src/main/webapp/app/login/services/login.ts.mustache
@@ -11,7 +11,7 @@ export const login = ({ username, password, rememberMe, setUsername, setToken }:
       password,
       rememberMe,
     })
-    .then(response => {
+    .then((response: { data: { id_token: string }}) => {
       setLocalStorage('token', response.data.id_token);
       setLocalStorage('username', username);
       setUsername(username);