Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit SCA recursive scan #2283

Merged
merged 18 commits into from
Nov 5, 2023
Merged

Audit SCA recursive scan #2283

merged 18 commits into from
Nov 5, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 24, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Depends on jfrog/jfrog-cli-core#994

We are introducing a new parameter to the Sca Audit command:

  • exclusions - You can specify exclusion patterns (wildcards) for files that should not be included in the mapping when detecting technologies, if not specified it will use the default exclusions set: ["*node_modules*", "*target*", "*venv*", "*test*"]

These parameters and capabilities will integrate with existing options as follows:

  • workingDir - If it doesn't exist, it will recursively detect the projects (and technologies) inside the current directory. If at least one value exists, it will perform technology detection only on the given directories without recursion.
  • Technologies flags (--npm, --maven, etc.) - If a specific technology flag is specified but not detected, it will only scan the root (the given working directory) with that technology.

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 25, 2023
@eyalbe4 eyalbe4 added the feature request New feature or request label Nov 1, 2023
utils/cliutils/commandsflags.go Outdated Show resolved Hide resolved
@attiasas attiasas added safe to test Approve running integration tests on a pull request new feature Automatically generated release notes and removed feature request New feature or request labels Nov 2, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 2, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@attiasas attiasas merged commit e839d03 into jfrog:dev Nov 5, 2023
53 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants