Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command results reader close error is ignored #2282

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 24, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

originError is always guaranteed to be non-nil since it inherently serves as a pointer to an error, even if the error it references happens to be nil. Furthermore, introducing the possibility of it being nil would lead to a panic in the code within the "if" block.

if originError == nil {
	*originError = e
}

@yahavi yahavi added the bug Something isn't working label Oct 24, 2023
@yahavi yahavi requested review from eyalbe4 and Or-Geva October 24, 2023 06:05
@yahavi yahavi self-assigned this Oct 24, 2023
@yahavi yahavi changed the title Command results reader close err is ignored Command results reader close error is ignored Oct 24, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@yahavi yahavi merged commit efae903 into jfrog:dev Oct 24, 2023
79 of 83 checks passed
@yahavi yahavi deleted the cmd-res-err branch October 24, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants