Infer collection_name from __table__ #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model classes that have been defined in a declarative style are not guaranteed to have a `__tablename__` attribute. For example, if they have been declared in a hybrid style with an embedded table:
class example(base):
__table__ = Table(...)
However even those declared just via a `__tablename_` will have a `__table__` attribute (created by the metaclass), so to infer the collection name in all cases we should use `__table__.name`.
jfinkels
added a commit
that referenced
this pull request
Feb 4, 2016
Infer collection_name from __table__ instead of __tablename__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model classes that have been defined in a declarative style are not guaranteed to have a
__tablename__attribute. For example, if they have been declared in a hybrid style with an embedded table:However even those declared just via a
__tablename_will have a__table__attribute (created by the metaclass), so to infer the collection name in all cases we should use__table__.name.