Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document testTimeout configuration option #9449

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

mriedem
Copy link
Contributor

@mriedem mriedem commented Jan 22, 2020

The testTimeout configuration option was documented in the CLI docs but not the configuration docs so I wasn't completely sure if it was available to use in my package.json configuration, so I needed to try it and also dig into the jest source code to confirm. This simply documents the option in the config docs as well.

Fixes #9448

@facebook-github-bot
Copy link
Contributor

Hi mriedem! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@mriedem
Copy link
Contributor Author

mriedem commented Jan 22, 2020

Hi mriedem! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Let me check with legal and get back to you...

@codecov-io
Copy link

Codecov Report

Merging #9449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9449   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files         283      283           
  Lines       12104    12104           
  Branches     2990     2990           
=======================================
  Hits         7863     7863           
  Misses       3604     3604           
  Partials      637      637

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7817dcc...9dba8b9. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! please update website/versioned_docs/version-25.1/Configuration.md as well

@mriedem
Copy link
Contributor Author

mriedem commented Jan 23, 2020

thanks! please update website/versioned_docs/version-25.1/Configuration.md as well

Sure, can do. I assumed the docs were auto-generated from source periodically but I'm also new here so...

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Jan 23, 2020

I assumed the docs were auto-generated from source periodically

We might land doc changes that are not in specific releases, so whenever we update the docs that also applies to an already published version we need to go back and edit the versioned docs as well

The `testTimeout` configuration option was documented
in the CLI docs but not the configuration docs so I wasn't
completely sure if it was available to use in my
package.json configuration, so I needed to try it and also
dig into the jest source code to confirm. This simply
documents the option in the config docs as well.

Fixes jestjs#9448
@SimenB SimenB merged commit eee8120 into jestjs:master Jan 24, 2020
@SimenB
Copy link
Member

SimenB commented Jan 24, 2020

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testTimeout is not documented in the config docs
4 participants