fix(sdk): use settings from SDK when there is no preexisting persiste…

…d data
jeremyckahn · Oct 27, 2023 · 51737da · 51737da
1 parent 9b6a13a
commit 51737da
Showing 1 changed file with 30 additions and 16 deletions.
diff --git a/src/Bootstrap.tsx b/src/Bootstrap.tsx
@@ -125,26 +125,40 @@ function Bootstrap({
           PersistedStorageKeys.USER_SETTINGS
         )
 
-      let configFromSdk = {}
-
-      try {
+      const computeUserSettings = async (): Promise<UserSettings> => {
         if (queryParams.has(QueryParamKeys.GET_SDK_CONFIG)) {
-          configFromSdk = await getConfigFromSdk()
+          try {
+            const configFromSdk = await getConfigFromSdk()
+
+            return {
+              ...userSettings,
+              ...persistedUserSettings,
+              ...configFromSdk,
+            }
+          } catch (e) {
+            console.error(
+              'Chitchatter configuration from parent frame could not be loaded'
+            )
+          }
+
+          return userSettings
         }
-      } catch (e) {
-        console.error(
-          'Chitchatter configuration from parent frame could not be loaded'
-        )
+
+        if (persistedUserSettings) {
+          return {
+            ...userSettings,
+            ...persistedUserSettings,
+          }
+        }
+
+        return userSettings
       }
 
-      if (persistedUserSettings) {
-        setUserSettings({
-          ...userSettings,
-          ...persistedUserSettings,
-          ...configFromSdk,
-        })
-      } else {
-        await persistUserSettings(userSettings)
+      const computedUserSettings = await computeUserSettings()
+      setUserSettings(computedUserSettings)
+
+      if (persistedUserSettings === null) {
+        await persistUserSettings(computedUserSettings)
       }
 
       setHasLoadedSettings(true)