feat(audio) [closes #180] Mute own screen stream (#200)

* refactor: remove redundant function calls * feat(video): [closes #180] mute self screen stream audio
jeremyckahn · Nov 4, 2023 · 3a97ee2 · 3a97ee2 · vercel · Nov 4, 2023
1 parent c0b76ff
commit 3a97ee2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/components/Room/PeerVideo.tsx b/src/components/Room/PeerVideo.tsx
@@ -8,6 +8,7 @@ import { VideoStreamType } from 'models/chat'
 import { SelectedPeerStream } from './RoomVideoDisplay'
 
 interface PeerVideoProps {
+  isSelfScreenStream?: boolean
   isSelfVideo?: boolean
   numberOfVideos: number
   onVideoClick?: (
@@ -29,6 +30,7 @@ const nextPerfectSquare = (base: number) => {
 }
 
 export const PeerVideo = ({
+  isSelfScreenStream,
   isSelfVideo,
   numberOfVideos,
   onVideoClick,
@@ -87,6 +89,7 @@ export const PeerVideo = ({
       >
         <video
           playsInline
+          muted={isSelfScreenStream}
           ref={videoRef}
           onClick={handleVideoClick}
           style={{

diff --git a/src/components/Room/RoomVideoDisplay.tsx b/src/components/Room/RoomVideoDisplay.tsx
@@ -173,6 +173,7 @@ export const RoomVideoDisplay = ({
         )}
         {selfScreenStream && (
           <PeerVideo
+            isSelfScreenStream
             numberOfVideos={numberOfVideos}
             onVideoClick={handleVideoClick}
             userId={userId}

diff --git a/src/components/Room/useRoomVideo.ts b/src/components/Room/useRoomVideo.ts
@@ -66,8 +66,6 @@ export function useRoomVideo({ peerRoom }: UseRoomVideoConfig) {
           type: VideoStreamType.WEBCAM,
         })
         setSelfVideoStream(newSelfStream)
-
-        setSelfVideoStream(newSelfStream)
       }
     })()
   }, [peerRoom, selfVideoStream, setSelfVideoStream])
@@ -144,7 +142,6 @@ export function useRoomVideo({ peerRoom }: UseRoomVideoConfig) {
           sendVideoChange(VideoState.STOPPED)
           setVideoState(VideoState.STOPPED)
           setSelfVideoStream(null)
-          setSelfVideoStream(null)
         }
       }
     })()