Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74169] Remove onClick handlers in MoPluginConfigView/freeTrialModal.jelly #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Dec 6, 2024

requires #9 - to use data-callback in task.jelly

Removes inline onclick handles to comply with CSP.

JENKINS-74169
JENKINS-74171

Testing done

After Changes [74169]
https://github.com/user-attachments/assets/b325c43e-bd08-44d1-9599-960c11bbb661

After Changes [74171]

Screen.Recording.2024-12-06.at.12.27.20.PM.mov

Steps to reproduce [74169]

  1. Navigate to Configure global security
  2. Under Security Realm, select: miniOrange SAML 2.0 -> then click Apply.
  3. Click on the here link -> opens up a page that shows a click here button for free trial.

Steps to reproduce [74171]

  1. Navigate to Configure global security
  2. Under Security Realm, select: miniOrange SAML 2.0 -> then click Apply.
  3. Click on the here link -> opens up a page that shows various config options

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan shlomomdahan marked this pull request as draft December 6, 2024 17:31
@shlomomdahan shlomomdahan marked this pull request as ready for review December 6, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant