Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading the pages takes too long #580

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

mPokornyETM
Copy link
Contributor

@mPokornyETM mPokornyETM commented Nov 16, 2023

see #558

This changes :

  • decreases the loading time for lockable-resources page
  • eliminates (partly) concurrent modification issues.
  • add new index column in the Queue page

Testing done

Manually tested. See screen shots
before:
image
image

after:

image

image

The differneces for User are really not vissble (instead of the queue index column) but loading times are rapidly decreased.

I does not have any numbers forcomparasion. But since we use this changes in your Jenkins instance no body call me, why it takes so long. That menas it works ;.) And we have ~ 700 labels.

Proposed upgrade guidelines

N/A

Localizations

All localizations files has been moved, hopefully are still correct

Submitter checklist

  • [ ] The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • [ ] There is automated testing or an explanation that explains why this change has no tests.
  • New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] For new APIs and extension points, there is a link to at least one consumer.
  • Any localizations are transferred to *.properties files.
  • [ ] Changes in the interface are documented also as examples.

@mPokornyETM mPokornyETM requested a review from a team as a code owner November 16, 2023 23:02
@mPokornyETM mPokornyETM added enhancement java Pull requests that update Java code ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.) localization ready for review PR is ready for review labels Nov 16, 2023
@mPokornyETM mPokornyETM added this to the Feature committed 2023 milestone Nov 16, 2023
@mPokornyETM mPokornyETM enabled auto-merge (squash) November 16, 2023 23:38
@mPokornyETM mPokornyETM added the megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours label Nov 17, 2023
@mPokornyETM
Copy link
Contributor Author

This changes will be merged without review with my admin rights.
Because no one of requested reviewer has provide the review over 1 week.
Hopefully is everybody fin with them.

@mPokornyETM mPokornyETM disabled auto-merge November 24, 2023 15:42
@mPokornyETM mPokornyETM merged commit 71f6e7c into jenkinsci:master Nov 24, 2023
1 of 2 checks passed
@mPokornyETM mPokornyETM deleted the page-load-performance branch November 24, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement java Pull requests that update Java code localization megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours ready for review PR is ready for review ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant