Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user defined properties to lockable resource #394

Conversation

mPokornyETM
Copy link
Contributor

@mPokornyETM mPokornyETM commented Nov 8, 2022

This changes enables to define properties per lockable-resource

image

close #299
fix #302

Testing done

Localizations

  • English
  • […]

Submitter checklist

  • The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.
  • Any localizations are transfered to *.properties files.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There is at least one (1) approval for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • java code changes are tested by automated test.

Gaspard Petit and others added 19 commits February 6, 2022 16:25
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
README.md Show resolved Hide resolved
@mPokornyETM mPokornyETM added the Triage Need to clarify, remove, close or whatever to clean up open issues / PRs label Feb 1, 2023
@mPokornyETM mPokornyETM added this to the Triage milestone Feb 1, 2023
@mPokornyETM mPokornyETM changed the title Eidosmontreal lockables with properties Add user defined properties to lockable resource Feb 7, 2023
@mPokornyETM mPokornyETM added wontfix work-in-progress and removed Triage Need to clarify, remove, close or whatever to clean up open issues / PRs labels Feb 7, 2023
@mPokornyETM mPokornyETM added java Pull requests that update Java code ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.) documentation test labels Feb 7, 2023
@mPokornyETM mPokornyETM marked this pull request as ready for review April 29, 2023 12:05
@mPokornyETM mPokornyETM requested a review from a team as a code owner April 29, 2023 12:05
@mPokornyETM mPokornyETM added extended properties Ideas about more aspects of the lockable resource instances than we had before new parameters/features enhancement log messages ready for review PR is ready for review and removed wontfix work-in-progress labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement extended properties Ideas about more aspects of the lockable resource instances than we had before java Pull requests that update Java code log messages new parameters/features ready for review PR is ready for review test ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple locks on resources based on attribute
3 participants