-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user defined properties to lockable resource #394
Merged
mPokornyETM
merged 26 commits into
jenkinsci:master
from
mPokornyETM:eidosmontreal-lockables-with-properties
May 2, 2023
Merged
Add user defined properties to lockable resource #394
mPokornyETM
merged 26 commits into
jenkinsci:master
from
mPokornyETM:eidosmontreal-lockables-with-properties
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
Fixes jenkinsci#300 : The order of the locked resources in the environment variable does not match the order in the extra parameter
This reverts commit be88b85.
This reverts commit 82a7770.
This reverts commit 1653c7b.
This reverts commit dfdfc5b.
…ontreal/lockable-resources-plugin into eidosmontreal-lockables-with-properties
…hub.com/mPokornyETM/lockable-resources-plugin into eidosmontreal-lockables-with-properties
mPokornyETM
commented
Nov 12, 2022
mPokornyETM
added
the
Triage
Need to clarify, remove, close or whatever to clean up open issues / PRs
label
Feb 1, 2023
mPokornyETM
changed the title
Eidosmontreal lockables with properties
Add user defined properties to lockable resource
Feb 7, 2023
mPokornyETM
added
wontfix
work-in-progress
and removed
Triage
Need to clarify, remove, close or whatever to clean up open issues / PRs
labels
Feb 7, 2023
mPokornyETM
added
java
Pull requests that update Java code
ui
Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
documentation
test
labels
Feb 7, 2023
mPokornyETM
added
extended properties
Ideas about more aspects of the lockable resource instances than we had before
new parameters/features
enhancement
log messages
ready for review
PR is ready for review
and removed
wontfix
work-in-progress
labels
May 1, 2023
g3n35i5
requested changes
May 2, 2023
src/main/java/org/jenkins/plugins/lockableresources/LockStepExecution.java
Outdated
Show resolved
Hide resolved
g3n35i5
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
enhancement
extended properties
Ideas about more aspects of the lockable resource instances than we had before
java
Pull requests that update Java code
log messages
new parameters/features
ready for review
PR is ready for review
test
ui
Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes enables to define properties per lockable-resource
close #299
fix #302
Testing done
Localizations
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease the future introduction of Content Security Policy (CSP) directives (see documentation).Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).