Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "New Crowdin updates" until we find why we have two sets of translated properties #370

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

gounthar
Copy link
Contributor

Reverts #369

@gounthar gounthar requested a review from a team as a code owner October 28, 2022 18:54
@gounthar gounthar enabled auto-merge October 28, 2022 18:54
@gounthar gounthar self-assigned this Oct 28, 2022
@gounthar gounthar mentioned this pull request Oct 28, 2022
@mPokornyETM
Copy link
Contributor

This is not necessary I found the why?. Fix coming soon, but is done in branch based on master. So when you close tis PR I gat merge conflict-. Pls wait for short time. I will test it on my node. Only to be sure.

@gounthar
Copy link
Contributor Author

Ok, thank you.

@gounthar gounthar merged commit 2b8f8c4 into master Oct 28, 2022
Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, please revert this changes, It looks it was added by crowdin action. I thing we shall check our crowdin config again.

Original (and correct one) is:
src\main\resources*org*\jenkins\plugins\lockableresources\Messages.properties

And crowdin add it new translations into:
src\main\resources*io*\jenkins\plugins\lockableresources

which is definitive wrong.

@gounthar gounthar deleted the revert-369-l10n_master branch October 28, 2022 20:14
@mPokornyETM
Copy link
Contributor

Good, that everybody understand what (and how) to do ;-)
b2c3a73
I think there is wrong path in ' translation:' key.

@mPokornyETM
Copy link
Contributor

@gounthar can you pls retry it ? Thx

@gounthar
Copy link
Contributor Author

gounthar commented Oct 28, 2022

I changed it before seeing your message, sorry about that.
I relaunched the synchronization, and it does not look bad now (see #371).
There is still (maybe) a problem, one of the property files seems to be missed by the configuration (because higher in the path).
https://github.com/jenkinsci/lockable-resources-plugin/blob/master/src/main/resources/org/jenkins/plugins/lockableresources/Messages.properties
Maybe that's a remnant of the previous translation system and should be ignored/deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants