Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-66785] Replace PNG logo with vectorized image #266

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[JENKINS-66785] Replace PNG logo with vectorized image #266

merged 1 commit into from
Oct 6, 2021

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Oct 3, 2021 •
edited
Loading

This PR aims to replace the PNG logo with a more modern looking like vectorized image.

Fixes: https://issues.jenkins.io/browse/JENKINS-66785

Before:

After:

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@NotMyFault NotMyFault changed the title [JENKINS-] Replace PNG logo with vectorized image [JENKINS-66785] Replace PNG logo with vectorized image Oct 3, 2021
@timja
Copy link
Member

timja commented Oct 6, 2021

cc @basil

(this does improve it although it would be getter to get a more appropriate symbol, this one is nonsense imo)

@timja timja requested a review from basil October 6, 2021 17:46
basil
basil approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 79bf764 into jenkinsci:master Oct 6, 2021
@NotMyFault NotMyFault deleted the feat/master/modernize-icon branch October 6, 2021 19:19
@basil
Copy link
Member

basil commented Oct 19, 2021

Released in 2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotMyFault @timja @basil