Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reservedTimestamp field #226

Closed
wants to merge 4 commits into from
Closed

Add reservedTimestamp field #226

wants to merge 4 commits into from

Conversation

primoz-p
Copy link
Contributor

@primoz-p primoz-p commented Dec 29, 2020 •
edited
Loading

  • added reservedTimestamp field
  • display it in lockabkle resource page
  • added unit tests

Fixes #225

RETWIFI-21462 Check "lockable/resource" plugin and update it
528c89e 
* added reservedTimestamp field
* display it in lockabkle resource page
* added unit tests
@primoz-p primoz-p changed the title RETWIFI-21462 Check "lockable/resource" plugin and update it Add reservedTimestamp field Dec 29, 2020
@primoz-p primoz-p mentioned this pull request Dec 29, 2020
Closed
@offa
Copy link
Contributor

offa commented Feb 17, 2021

@TobiX can you have a look at the PR? It's a really useful feature.

@offa
Copy link
Contributor

offa commented Apr 26, 2021

Ping @basil

@basil
Copy link
Member

basil commented Apr 26, 2021

Hi @offa, I will look at this eventually but it is going to take some time. I am not currently familiar with this codebase, so I will need to spend some time reading the code and fixing some bugs before I can review new features.

@offa
Copy link
Contributor

offa commented Apr 26, 2021

No problem, thanks for the info!

@rnickle79
Copy link

Any chance this can be included in the next release?

@primoz-p primoz-p closed this Jul 1, 2021
@primoz-p primoz-p deleted the feature/RETWIFI-21462 branch July 1, 2021 13:24
@offa
Copy link
Contributor

offa commented Sep 13, 2021

Is there a chance to revive this PR?

@offa
Copy link
Contributor

offa commented Oct 11, 2021

Ping @basil @primoz-p

@bignay2000
Copy link

Just added this plugin to my deployments, a time stamp would be very useful!

@offa
Copy link
Contributor

offa commented Nov 22, 2021

@basil in case there are issue left, I can volunteer to address them.

@basil
Copy link
Member

basil commented Nov 22, 2021

@offa Are you interested in becoming a maintainer of this plugin? Feel free to file a repository-permissions-updater PR and I'll approve.

@offa
Copy link
Contributor

offa commented Nov 24, 2021

I can't commit as a maintainer unfortunately. But I try to give a helping hand here and there.

@offa offa mentioned this pull request Nov 24, 2021
Merged
6 tasks
jimklimov added a commit that referenced this pull request Feb 2, 2022
@jimklimov
Merge pull request #273 from offa/reserved_timestamp
d54f204 
Reserved timestamp and editable note (continuation of #226)
@jimklimov
Copy link
Contributor

Thanks @primoz-p for the feature and to @offa handling the PR concerns above via PR #273, and for patience! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reserved timestamp field in locable resource list
6 participants
@primoz-p @offa @basil @rnickle79 @bignay2000 @jimklimov