Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hashes for third party action #7584

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Use hashes for third party action #7584

merged 1 commit into from
Jan 16, 2023

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jan 16, 2023 •
edited
Loading

Amends #7285 and partially implements recommendation surfaced in #7113 to not use mutable refs. https://github.com/softprops/action-gh-release/releases/tag/v1 currently points to de2c0eb89ae2a093876385947365aca7b0e5f844 so I used that.

Untested. Lazy branch, please delete on merge.

@daniel-beck daniel-beck added internal skip-changelog Should not be shown in the changelog labels Jan 16, 2023
NotMyFault
NotMyFault approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

@NotMyFault NotMyFault merged commit 1d97741 into master Jan 16, 2023
@NotMyFault NotMyFault deleted the third-party-action-hashes branch January 16, 2023 12:01
@daniel-beck daniel-beck mentioned this pull request Nov 29, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
internal skip-changelog Should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-beck @NotMyFault