Do not attempt to shade dependencies #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was introduced in jenkinsci@49dc7bc but this is a waste of space. as the shade runs after the hpi package all that happens is that the classess get copied into the root of the HPI. classes are never loaded from here and there is a copy in WEB-INF\lib\gcp-client-xxx.jar that is used, and this has been working for a while. whilst there may also be a gcp-client in other places that this plugin has dependencies to I saw no gcp-client in google-oath-credentials wheich would be the only logical place. Additionally if it where not broken before this fix it would remain not broken after this fix.
raul-arabaolaza
approved these changes
May 3, 2024
basil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was introduced in
49dc7bc but this is a waste of space.
as the shade runs after the hpi package all that happens is that the classess get copied into the root of the HPI.
classes are never loaded from here and there is a copy in
WEB-INF\lib\gcp-client-xxx.jarthat is used, and this has been working for a while.whilst there may also be a
gcp-clientor classes in other places that this plugin has dependencies to I saw no gcp-client ingoogle-oath-credentialswhich would be the only logical place. Additionally if it was not broken before this fix it would remain not broken after this fix.Testing done
none.
Submitter checklist