[JENKINS-64141] Restore localhost as default SMTP server #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Based on my reading of the code, the original behavior in Email Extension 2.77 and earlier technically only allowed a blank SMTP server for the default account (not for additional accounts), but I think allowing a blank SMTP server in all cases as in this PR makes more sense. |
|
Released in 2.80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-64141.
This is a very minimal change to restore a pre-2.79 behavior: having no SMTP server address (the default setting) means
localhostwill be used, which is often the right choice.I've kept the
MailAccount.isSmtpServerValid()method around, because it could still be a place to implement other controls (like checking that the value, if any, looks like an FQDN or IP address), but it now always returnstrue.